Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make documentLoader required #32

Open
OR13 opened this issue Aug 17, 2020 · 2 comments
Open

Make documentLoader required #32

OR13 opened this issue Aug 17, 2020 · 2 comments

Comments

@OR13
Copy link

OR13 commented Aug 17, 2020

https://github.com/transmute-industries/jsonld-document-loader

^ any time a document loader is used, it should be explicitly required, and some reasonable defaults should be recommended.
@gjgd
Copy link
Owner

gjgd commented Aug 19, 2020 •
edited
Loading

Added the possibility to pass a custom document loader: #33

https://github.com/gjgd/jsonld-checker#passing-a-custom-document-loader

published version: [email protected]

@gjgd gjgd closed this as completed Aug 19, 2020
@OR13
Copy link
Author

OR13 commented Aug 19, 2020

still prefer to never use a "defaultDocumentLoader"... consider adding a warning when the default one is used.

@gjgd gjgd reopened this Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gjgd @OR13