[papi] add watchWorkspace API #19010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
mustard-mh
force-pushed
the
hw/watch-workspace
branch
from
68b9a2f to
b9c02d9
Compare
mustard-mh
force-pushed
the
hw/watch-workspace
branch
from
ef17d55 to
145584c
Compare
mustard-mh
commented
Nov 7, 2023
|
|
||
| message WatchWorkspaceStatusResponse { | ||
| // workspace_id is the ID of the workspace that has status updated | ||
| string workspace_id = 1; |
There was a problem hiding this comment.
We need workspace_id since there's no workspace_id field in WorkspaceStatus
mustard-mh
commented
Nov 7, 2023
mustard-mh
commented
Nov 7, 2023
akosyakov
reviewed
Nov 7, 2023
akosyakov
reviewed
Nov 7, 2023
akosyakov
reviewed
Nov 7, 2023
akosyakov
reviewed
Nov 7, 2023
akosyakov
reviewed
Nov 7, 2023
| if (req.workspaceId && instance.workspaceId !== req.workspaceId) { | ||
| continue; | ||
| } | ||
| const status = this.apiConverter.toWorkspace(instance).status; |
There was a problem hiding this comment.
to me to understand if here happens some exception what happens with it?
akosyakov
approved these changes
Nov 7, 2023
mustard-mh
changed the title
Going to remove test commits and merge |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Copilot
🤖 Generated by Copilot at 4ac219e
This pull request adds a new feature to the
WorkspaceServiceservice that allows clients to stream updates about the status of a workspace. It defines the newWatchWorkspaceRPC method and its message types in theworkspace.protofile, and implements it in theservercomponent using theconnectandgrpclibraries. It also adds support for the new method to the TypeScript client library. Additionally, it updates the@types/nodedependency to a compatible version.Related Issue(s)
Fixes #
How to test
With debug commit (hot-deployed) 50e7527
window.$testWatchto watch statusdashboard_public_api_enabledfeature flag======disposein server✅ Test result share
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold