Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Outdated and Safe-to-Delete Feature Flags #18899

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

Siddhant-K-code
Copy link
Member

@Siddhant-K-code Siddhant-K-code commented Oct 9, 2023

Description

This PR removes two feature flags which have no code-references:

  • publicApiExperimentalWorkspaceService already deleted from ConfigCat dashboard. See (internal conversation)
  • showUseLastSuccessfulPrebuild - On in Preview environments (but no code references) & Off in Prod. for Gitpod Cloud (last touched on 2022.10.19) -- Needs to be deleted from Configcat Dashboard after this PR. Also, Related WEB-216
Summary generated by Copilot

🤖 Generated by Copilot at 4f0ab6b

Remove unused feature flags from dashboard query. This simplifies the code and avoids querying unnecessary data.

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Siddhant-K-code
Copy link
Member Author

/unhold

@roboquat roboquat merged commit eaa7051 into main Oct 12, 2023
48 of 50 checks passed
@roboquat roboquat deleted the siddhant/feature-flags-cleanup branch October 12, 2023 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants