Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metrics] surface user agent and original error timestamp #18803

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Sep 26, 2023

Description

In order to see error rates by user agents. It does not parse it to separate browser, os, and its version, but we can do a break down using filters on raw data.

Summary generated by Copilot

🤖 Generated by Copilot at ea609a8

Improve error reporting in metrics.ts by adding more details and a queue system.

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

const properties = {
...data,
...this.options.commonErrorDetails,
onLine: window.navigator.onLine,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL 💡

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM ✔️

@akosyakov akosyakov force-pushed the ak/metrics_user_agent branch 2 times, most recently from 65d3450 to 3c77b9d Compare September 26, 2023 19:59
@akosyakov akosyakov force-pushed the ak/metrics_user_agent branch from 3c77b9d to 3fd698d Compare September 26, 2023 20:39
@akosyakov
Copy link
Member Author

/unhold

@roboquat roboquat merged commit 1b68720 into main Sep 26, 2023
12 of 13 checks passed
@roboquat roboquat deleted the ak/metrics_user_agent branch September 26, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants