[fga] check workspace relationships #18793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing, though... 🤔 Can check in ~40mins |
svenefftinge
force-pushed
the
se/fga-workspace-check
branch
from
002c934 to
b57de09
Compare
Funny enough, I cannot reproduce that failure in my dev environment, but it looks like a case for the sporadic write failure we are trying to tackle. 🤔 Edit: The causing error is here. Haven't seen that before and couldn't find anything using google. |
svenefftinge
force-pushed
the
se/fga-workspace-check
branch
from
b57de09 to
765b149
Compare
|
This happens reliably when running |
svenefftinge
force-pushed
the
se/fga-workspace-check
branch
from
765b149 to
1c99024
Compare
|
Turned out to be a problem with the in memory mode of spicedb we use in testing. (issue) So I changed the code to write the relationships sequentially. |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have identified that sometimes workspace relationships are missing without any error from spicedb.
We used to write them in large chunks. This changes them taht and writes the workspace rleationship per workspace. In addition it checks if the rleationships have actually been written successfully.
Summary generated by Copilot
🤖 Generated by Copilot at 002c934
This pull request updates the authorization database migration logic and adds a temporary verification check. The changes aim to improve the robustness and consistency of the new authorization model for workspaces, organizations, and users.
Related Issue(s)
Fixes #
How to test
Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold