Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup installer #18784

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Cleanup installer #18784

merged 2 commits into from
Sep 25, 2023

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Sep 22, 2023 •
edited by github-actions bot
Loading

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=workspace
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@aledbf aledbf force-pushed the aledbf/cleanup-installer branch from f892ba4 to 5e587c8 Compare September 22, 2023 23:48
@roboquat roboquat added size/L and removed size/M labels Sep 22, 2023
@aledbf aledbf marked this pull request as ready for review September 23, 2023 00:14
@aledbf aledbf requested review from a team as code owners September 23, 2023 00:14
@aledbf
Copy link
Member Author

aledbf commented Sep 24, 2023

/gh run recreate-vm

@aledbf
Copy link
Member Author

aledbf commented Sep 24, 2023 •
edited by github-actions bot
Loading

/gh run recreate-vm

Comment triggered a workflow run

Started workflow run: 6292778851

  • recreate_vm: true

geropl
geropl approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did not test

@roboquat roboquat merged commit d464ef8 into main Sep 25, 2023
1 check passed
@roboquat roboquat deleted the aledbf/cleanup-installer branch September 25, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

@WVerlaek WVerlaek WVerlaek approved these changes

Assignees
No one assigned
Labels
size/L team: team-engine team: team-experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aledbf @WVerlaek @geropl @roboquat