Add default image get to PAPI and improve Dashboard #18767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mustard-mh
commented
Sep 21, 2023
| <Alert className="w-96 mt-4" type="warning"> | ||
| A custom <span className="font-medium">default workspace image</span> is set for this organization. Contact | ||
| an organization owner or specify a different image in <code>.gitpod.yml</code>. | ||
| </Alert> |
There was a problem hiding this comment.
We may need to update this warning message since we can't identify if current workspace were started with org default workspace. See How to Test section Not part.
cc @gtsiolis @filiptronicek If you have good idea about it
mustard-mh
changed the title
|
Looking at this now! 👀 |
gtsiolis
reviewed
Sep 21, 2023
There was a problem hiding this comment.
Thanks, @mustard-mh. Left some comments below. Let me know what you think.
Co-authored-by: George Tsiolis <[email protected]>
gtsiolis
reviewed
Sep 21, 2023
|
@akosyakov Could you take a look at PublicAPI part? 🙏 |
akosyakov
reviewed
Sep 22, 2023
| workspaceId?: string; | ||
| } | ||
|
|
||
| export type DefaultImageSource = |
akosyakov
approved these changes
Sep 22, 2023
|
@gtsiolis Good if I unhold this PR? (ask because addressed feedbacks are not marked as resolved yet) |
|
@mustard-mh Yes, resolved any pending UX comments. Leaving this to you. 🏓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improved:
gp validateandgp init)Default Imagelabeltag👉 Warning on Start Workspace page
Summary generated by Copilot
🤖 Generated by Copilot at 00ee208
Added a new RPC and public API endpoint to get the default workspace image from different sources. Refactored the dashboard and protocol components to use strings instead of objects for the image props. Removed unused dummy fields and methods from the public API. Added mock and proxy implementations for testing and connecting the services.
Related Issue(s)
Fixes EXP-631, EXP-633
How to test
SHOULD - Dashboard
node:20-alpine3.17gitpod/workspace-baseSHOULD - GP-CLI
Check
gp validateandgp initas #18723 's description, there should have no regression❌ NOT
It's marked as
NOTsince we have no way to identify which image current workspace is using now.It's marked as
NOTsince we have no way to identify which org image current workspace is using now.Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold