Fix react-query cache persistence #18762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gh run |
gtsiolis
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
Preview environment is not working but UX LGTM in the screenshot. 🏁
Thanks @selfcontained. 🌮
I kinda miss the differentiation of the project, but hopefully we can get back to it soon.
svenefftinge
approved these changes
Sep 21, 2023
AlexTugarev
reviewed
Sep 21, 2023
| @@ -29,7 +29,9 @@ const UserContextProvider: React.FC = ({ children }) => { | |||
| const doSetUser = useCallback( | |||
| (updatedUser: User) => { | |||
| updateErrorUserDetails(updatedUser); | |||
| if (user?.id !== updatedUser.id) { | |||
| // If user has changed clear cache | |||
| // Ignore the case where user hasn't been set yet - initial load | |||
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Found a bug where we end up always clearing the query cache on page load. This adjusts some of the logic with where/how we reset that cache so we benefit from loading up the cache from IDB.
Instead of the logic that was there, which would clear the cache anytime the user id changes in
UserContext, I've adjust it to only do that when we have a user in context already. This avoids clearing it on initial page load. I've also added explicit clearing of the cache on logout and login.I've also updated the icons in the repository selector to remove the color distinction between projects non-project suggestions. We may revisit the iconography and colors later.
Summary generated by Copilot
🤖 Generated by Copilot at 1e0af49
This pull request enhances the data fetching and caching logic for the login and user menu components, using React Query hooks and clearing the cache when appropriate. It also improves the user context management by syncing it with the query cache.
Related Issue(s)
Fixes EXP-655
How to test
/newpage for creating a new workspace.Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold