-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support jb plugins from image #18732
Conversation
7ba9460
to
f29fa90
Compare
/gh run recreate-vm=true Comment triggered a workflow runStarted workflow run: 6222345290
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
log.WithField("plugin", file.Name()).Info("plugin is already synced, skipping") | ||
return nil | ||
} | ||
return exec.Command("cp", "-rf", filepath.Join(srcDir, file.Name()), destDir).Run() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(not-blocking): Use golang instead of exec cp
command (most images should have cp
so it's a nit-suggestion)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, i think we discussed when we introduced options, and decided just to use cp
but just of curiosity what would use if you go with golang
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
filepath.Walk
or lib like github.com/otiai10/copy
, but cp
can be a good option too
@mustard-mh you need to approve it 🙏 |
/unhold |
Description
It allows to distribute JB plugins (similarly how we do it for options) as part of the image instead of using JB marketplace or custom repositories. It is helpful in case of proprietary plugins which should be distributed org wide.
Summary generated by Copilot
🤖 Generated by Copilot at 7ba9460
This pull request enhances the JetBrains IDE integration by enabling plugin synchronization. It extracts common logic for syncing files from the workspace context to the IDE and applies it to both options and plugins. It also handles the necessary steps for unpacking plugin archives and updating the system path.
Related Issue(s)
fix EXP-626
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-test
Publish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh
. If enabled,with-preview
andwith-large-vm
will be enabled./hold