[code] Pass GITPOD_CODE_HOST when starting vscode server #18730
Conversation
|
/gh run recreate-vm Comment triggered a workflow runStarted workflow run: 6209087373
|
jeanp413
force-pushed
the
jp/temporary-seahorse
branch
from
d647483 to
a00bf47
Compare
|
/gh run recreate-vm Comment triggered a workflow runStarted workflow run: 6215455970
|
|
Seems there's a bug in our open-vsx proxy:
|
| @@ -61,14 +61,21 @@ func main() { | |||
| } | |||
| phaseDone() | |||
|
|
|||
| url, err := url.Parse(wsInfo.GitpodHost) | |||
There was a problem hiding this comment.
We have only codehelper which should work with all images. Let's keep backward compatible mode based on version from product.json.
We will need to keep old rules in installer as well.
We can only remove them when all Dedicated cells and Cloud are migrated to new images.
There was a problem hiding this comment.
This is just 💄 as GitpodHost was parsed twice in prepareServerMain and prepareWebWorkbenchMain, the functions will still be invoked correctly for all versions, GITPOD_CODE_HOST env var will be ignored for old versions
| }, { | ||
| Search: "{{extensionsGalleryItemUrl}}", | ||
| Replacement: extensionsGalleryItemUrl, | ||
| Path: "/ide/out/vs/workbench/workbench.web.api.js", | ||
| }, { | ||
| Search: "{{extensionsGalleryItemUrl}}", | ||
| Replacement: extensionsGalleryItemUrl, | ||
| Path: "/ide/out/vs/workbench/workbench.web.main.js", | ||
| }, { | ||
| Search: "{{trustedDomain}}", | ||
| Replacement: trustedDomain, | ||
| Path: "/ide/out/vs/workbench/workbench.web.api.js", |
There was a problem hiding this comment.
workbench.web.api.js file does not exist a long time ago so it's fine to delete these rules
| }, { | ||
| Search: "${window.location.origin}", | ||
| Replacement: ".", | ||
| }, { | ||
| Search: "value.startsWith(window.location.origin)", | ||
| Replacement: "value.startsWith(window.location.origin) || value.startsWith('${ide}')", | ||
| }, { | ||
| Search: "./out", | ||
| Replacement: "${ide}/out", | ||
| }, { | ||
| Search: "./node_modules", | ||
| Replacement: "${ide}/node_modules", |
There was a problem hiding this comment.
These search values do not exist in index.html a long time ago so removing them it's fine
jeanp413
force-pushed
the
jp/temporary-seahorse
branch
from
28da6f7 to
0dcc3a5
Compare
|
|
|
/gh run recreate-vm Comment triggered a workflow runStarted workflow run: 6230900477
|
|
/gh run recreate-vm Comment triggered a workflow runStarted workflow run: 6243722056
|
|
Tested stable and insiders, both work 🎉 |
Description
Related gitpod-io/openvscode-server@8bcdbe5
Summary generated by Copilot
🤖 Generated by Copilot at a526592
Switched the code-server component to use the open-vsx proxy for extensions and refactored the codehelper package to support different domains. Simplified the code-server Dockerfile and updated the workspace configuration.
Related Issue(s)
Fixes #
How to test
Check both vscode stable and insiders works:
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold