Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable hmr for dashboard #18679

Merged
merged 1 commit into from
Sep 7, 2023
Merged

enable hmr for dashboard #18679

merged 1 commit into from
Sep 7, 2023

Conversation

selfcontained
Copy link
Contributor

@selfcontained selfcontained commented Sep 7, 2023

Description

Updating the webpack config so hot module reloading works for development. This stopped working after our webpack upgrade, so I'm guessing something changed w/ that that causes us to need this now.

Summary generated by Copilot

🤖 Generated by Copilot at 400e349

This pull request enables hot module replacement for the dashboard component in both local and Gitpod development environments. It adds a devServer configuration to craco.config.js and two environment variables to the start script in package.json.

How to test

  • Start a workspace on this branch
  • cd components/dashboard
  • yarn start
  • Then make port 3000 public and grab that url.
  • Load https://gitpod-staging.com and setup the x-frontend-dev-url header w/ a browser extension to use that url.
  • Ensure that app loads, you should see an icon in the bottom right if it's using your dev server.
  • Make a change and you should see it reflected w/o a page reload

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link
Member

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@selfcontained
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit b2bd7fc into main Sep 7, 2023
@roboquat roboquat deleted the brad/dashboard-hmr-config branch September 7, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants