From 97149127999909f6a730c1aca5a753d39e98d8aa Mon Sep 17 00:00:00 2001 From: Pudong Zheng Date: Fri, 26 Apr 2024 16:14:00 +0000 Subject: [PATCH] cleanup --- .github/workflows/build.yml | 3 --- dev/preview/workflow/preview/build.sh | 3 --- dev/preview/workflow/preview/deploy-gitpod.sh | 1 - install/preview/prettylog/BUILD.yaml | 10 ---------- 4 files changed, 17 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 058512fb9e85c5..6f22138ef78b17 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -203,7 +203,6 @@ jobs: uses: "google-github-actions/get-secretmanager-secrets@v1" with: secrets: |- - segment-io-token:gitpod-core-dev/segment-io-token npm-auth-token:gitpod-core-dev/npm-auth-token jb-marketplace-publish-token:gitpod-core-dev/jb-marketplace-publish-token codecov-token:gitpod-core-dev/codecov @@ -245,7 +244,6 @@ jobs: NODE_OPTIONS: "--max_old_space_size=4096" JAVA_HOME: /home/gitpod/.sdkman/candidates/java/current VERSION: ${{needs.configuration.outputs.version}} - SEGMENT_IO_TOKEN: "${{ steps.secrets.outputs.segment-io-token }}" PR_NO_CACHE: ${{needs.configuration.outputs.build_no_cache}} PR_NO_TEST: ${{needs.configuration.outputs.build_no_test}} NPM_AUTH_TOKEN: "${{ steps.secrets.outputs.npm-auth-token }}" @@ -270,7 +268,6 @@ jobs: --docker-build-options network=host \ --max-concurrent-tasks 1 \ -DlocalAppVersion=$VERSION \ - -DSEGMENT_IO_TOKEN=$SEGMENT_IO_TOKEN \ -DpublishToNPM="${PUBLISH_TO_NPM}" \ -DnpmPublishTrigger="${NPM_PUBLISH_TRIGGER}" \ -DpublishToJBMarketplace="${PUBLISH_TO_JBPM}" \ diff --git a/dev/preview/workflow/preview/build.sh b/dev/preview/workflow/preview/build.sh index 4e94aef97ff633..a9aade83f2be0f 100755 --- a/dev/preview/workflow/preview/build.sh +++ b/dev/preview/workflow/preview/build.sh @@ -13,8 +13,6 @@ import "ensure-gcloud-auth.sh" leeway run dev/preview:configure-workspace ensure_gcloud_auth -PREVIEW_GCP_PROJECT=gitpod-dev-preview - if [[ "${VERSION:-}" == "" ]]; then VERSION="$(previewctl get name)-dev-$(date +%F_T%H-%M-%S)" log_info "VERSION is not set - using $VERSION" @@ -22,7 +20,6 @@ if [[ "${VERSION:-}" == "" ]]; then fi leeway build \ - -DSEGMENT_IO_TOKEN="$(gcloud secrets versions access latest --project ${PREVIEW_GCP_PROJECT} --secret=segment-io-token)" \ -Dversion="${VERSION}" \ --dont-test \ dev/preview:deploy-dependencies diff --git a/dev/preview/workflow/preview/deploy-gitpod.sh b/dev/preview/workflow/preview/deploy-gitpod.sh index a42d3311d9407b..58d33aca6be6d6 100755 --- a/dev/preview/workflow/preview/deploy-gitpod.sh +++ b/dev/preview/workflow/preview/deploy-gitpod.sh @@ -52,7 +52,6 @@ if ! test -f "/tmp/versions.yaml"; then leeway build components:all-docker \ --dont-test \ -Dversion="${VERSION}" \ - -DSEGMENT_IO_TOKEN="$(gcloud secrets versions access latest --project ${PREVIEW_GCP_PROJECT} --secret=segment-io-token)" \ --save "${VERSIONS_TMP_ZIP}" tar -xzvf "${VERSIONS_TMP_ZIP}" ./versions.yaml && sudo mv ./versions.yaml /tmp/versions.yaml rm "${VERSIONS_TMP_ZIP}" diff --git a/install/preview/prettylog/BUILD.yaml b/install/preview/prettylog/BUILD.yaml index fb4f7c56e80b2c..dcafd77f4d6a69 100644 --- a/install/preview/prettylog/BUILD.yaml +++ b/install/preview/prettylog/BUILD.yaml @@ -5,8 +5,6 @@ packages: - name: app type: go - argdeps: - - SEGMENT_IO_TOKEN srcs: - "main.go" - "go.sum" @@ -15,11 +13,3 @@ packages: - CGO_ENABLED=0 config: packaging: app - buildCommand: - [ - "go", - "build", - "-trimpath", - "-ldflags", - "-buildid= -w -s -X 'main.segmentIOToken=${SEGMENT_IO_TOKEN}'", - ]