Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual File History: add back telemetry on event hooks #3782

Open
d13 opened this issue Nov 19, 2024 · 0 comments
Open

Visual File History: add back telemetry on event hooks #3782

d13 opened this issue Nov 19, 2024 · 0 comments
Labels
area-visual-file-history Issues or features related to the Visual File History

Comments

@d13
Copy link
Member

d13 commented Nov 19, 2024

We removed tracking the toggling of legend items because adding events hooks stopped the default behavior of the interaction and we didn't want to re-implement that outside the component.

The Billboard team has made a change to expose the current visibility state of the item, so we can just call their methods and not need to separately maintain state.

@d13 d13 added the area-visual-file-history Issues or features related to the Visual File History label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-visual-file-history Issues or features related to the Visual File History
Projects
None yet
Development

No branches or pull requests

1 participant