Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Requests and Issues seem incorrect in develop release #66

Open
DRuggeri opened this issue Dec 29, 2020 · 0 comments
Open

Pull Requests and Issues seem incorrect in develop release #66

DRuggeri opened this issue Dec 29, 2020 · 0 comments

Comments

@DRuggeri
Copy link

Hey there. First, thank you for your work on this exporter. As maintainer as a bunch of exporters myself, I appreciate what y'all are doing!

I've built from the latest pre-release (Development Release - 02) and detect what appears to be incorrect PR/issues data. When setting the following parameters via ENV:

  • USERS=DRuggeri
  • OPTIONAL_METRICS=pulls

I get the following (reduced) results:

# TYPE github_repo_open_issues gauge
github_repo_open_issues{archived="false",fork="false",language="",license="mit",private="false",repo="OSSClass",user="DRuggeri"} 2
github_repo_open_issues{archived="false",fork="false",language="C",license="other",private="false",repo="crystalfontz-lcd-cmd",user="DRuggeri"} 0
github_repo_open_issues{archived="false",fork="false",language="Dockerfile",license="",private="false",repo="devkits",user="DRuggeri"} 0
github_repo_open_issues{archived="false",fork="false",language="Go",license="apache-2.0",private="false",repo="alertmanager_gotify_bridge",user="DRuggeri"} 0
github_repo_open_issues{archived="false",fork="false",language="Go",license="other",private="false",repo="bind_query_exporter",user="DRuggeri"} 0
github_repo_open_issues{archived="false",fork="false",language="Go",license="other",private="false",repo="dhcpd_leases_exporter",user="DRuggeri"} 0
github_repo_open_issues{archived="false",fork="false",language="Go",license="other",private="false",repo="dhcpdleasesreader",user="DRuggeri"} 0
github_repo_open_issues{archived="false",fork="false",language="Go",license="other",private="false",repo="netgear_client",user="DRuggeri"} 0
github_repo_open_issues{archived="false",fork="false",language="Go",license="other",private="false",repo="netgear_exporter",user="DRuggeri"} 0
github_repo_open_issues{archived="false",fork="false",language="Go",license="other",private="false",repo="nut_exporter",user="DRuggeri"} 0
github_repo_open_issues{archived="false",fork="true",language="JavaScript",license="mit",private="false",repo="jsvectormap",user="DRuggeri"} 0
# HELP github_repo_pull_request_count Total number of pull requests for given repository
# TYPE github_repo_pull_request_count gauge
github_repo_pull_request_count{archived="false",fork="false",language="",license="mit",private="false",repo="OSSClass",user="DRuggeri"} 2
github_repo_pull_request_count{archived="false",fork="false",language="C",license="other",private="false",repo="crystalfontz-lcd-cmd",user="DRuggeri"} 0
github_repo_pull_request_count{archived="false",fork="false",language="Dockerfile",license="",private="false",repo="devkits",user="DRuggeri"} 0
github_repo_pull_request_count{archived="false",fork="false",language="Go",license="apache-2.0",private="false",repo="alertmanager_gotify_bridge",user="DRuggeri"} 0
github_repo_pull_request_count{archived="false",fork="false",language="Go",license="other",private="false",repo="bind_query_exporter",user="DRuggeri"} 0
github_repo_pull_request_count{archived="false",fork="false",language="Go",license="other",private="false",repo="dhcpd_leases_exporter",user="DRuggeri"} 0
github_repo_pull_request_count{archived="false",fork="false",language="Go",license="other",private="false",repo="dhcpdleasesreader",user="DRuggeri"} 0
github_repo_pull_request_count{archived="false",fork="false",language="Go",license="other",private="false",repo="netgear_client",user="DRuggeri"} 0
github_repo_pull_request_count{archived="false",fork="false",language="Go",license="other",private="false",repo="netgear_exporter",user="DRuggeri"} 0
github_repo_pull_request_count{archived="false",fork="false",language="Go",license="other",private="false",repo="nut_exporter",user="DRuggeri"} 0
github_repo_pull_request_count{archived="false",fork="true",language="JavaScript",license="mit",private="false",repo="jsvectormap",user="DRuggeri"} 0

As can be confirmed by viewing the OSSClass repository, there are no issues... but there ARE two pull requests.

This functionality also seems broken in the current stable release. That version shows NO data for pull requests... but shows open issues as the number of pulls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant