Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad link to supported package ecosystem in 'Code Security > Explore dependencies' #35360

Closed
1 task done
julien-deramond opened this issue Nov 20, 2024 · 3 comments · Fixed by #35371
Closed
1 task done
Labels
code security Content related to code security content This issue or pull request belongs to the Docs Content team help wanted Anyone is welcome to open a pull request to fix this issue

Comments

@julien-deramond
Copy link
Contributor

julien-deramond commented Nov 20, 2024

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/code-security/supply-chain-security/understanding-your-software-supply-chain/exploring-the-dependencies-of-a-repository#changing-the-used-by-package

What part(s) of the article would you like to see updated?

In this section, there's this link:

Your repository contains a package that is published on a supported package ecosystem.

However, there's no #supported-package-ecosystems anchor in the target page.

The right link is probably rather code-security/supply-chain-security/understanding-your-software-supply-chain/dependency-graph-supported-package-ecosystems#supported-package-ecosystemshttps://docs.github.com/en/code-security/supply-chain-security/understanding-your-software-supply-chain/dependency-graph-supported-package-ecosystems#supported-package-ecosystems

Additional information

If needed, I can create a PR containing this fix, please let me know.

@julien-deramond julien-deramond added the content This issue or pull request belongs to the Docs Content team label Nov 20, 2024
Copy link

welcome bot commented Nov 20, 2024

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 20, 2024
@nguyenalex836
Copy link
Contributor

@julien-deramond Thank you for raising this issue! I'll get this triaged for review ✨ Our team will provide feedback regarding the best next steps for this issue - thanks for your patience! 💛

@nguyenalex836 nguyenalex836 added waiting for review Issue/PR is waiting for a writer's review code security Content related to code security and removed triage Do not begin working on this issue until triaged by the team waiting for review Issue/PR is waiting for a writer's review labels Nov 20, 2024
@am-stead
Copy link
Contributor

👋 @julien-deramond

Thanks very much for spotting this! I agree with you that the correct link here should be:

You, or anyone else, would be very welcome to open a PR for the fix! 💜

@nguyenalex836 nguyenalex836 added help wanted Anyone is welcome to open a pull request to fix this issue and removed waiting for review Issue/PR is waiting for a writer's review labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code security Content related to code security content This issue or pull request belongs to the Docs Content team help wanted Anyone is welcome to open a pull request to fix this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants