Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update telling-git-about-your-signing-key.md #34401

Closed
wants to merge 4 commits into from

Conversation

alexmazaltov
Copy link

@alexmazaltov alexmazaltov commented Aug 26, 2024

add alternative command for fish shell

Why: cause it is not obvious how to deal with gpg signature using fish shell

Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

add alternative command for fish shell
Copy link

welcome bot commented Aug 26, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 26, 2024
Copy link
Contributor

github-actions bot commented Aug 26, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
authentication/managing-commit-signature-verification/telling-git-about-your-signing-key.md fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review authentication Content relating to authentication and removed triage Do not begin working on this issue until triaged by the team labels Aug 27, 2024
@nguyenalex836
Copy link
Contributor

@alexmazaltov Thanks so much for opening a PR! I'll get this triaged for review ✨

@alexmazaltov
Copy link
Author

@nguyenalex836 thank you for your time

@alexmazaltov
Copy link
Author

@nguyenalex836 please review

@subatoi
Copy link
Contributor

subatoi commented Sep 2, 2024

Hi @alexmazaltov, and thanks for your submission and interest in the docs—

As a rule, we target Bash. I think we can make that fact clearer in our contributing documentation and I'll discuss that internally. There are potentially many more places other than this one where we could add examples that are specific to other shells, and unless there's a very specific reason to call one out in particular, we wouldn't make an exception, so for that reason I'm afraid we won't be accepting this submission right now.

I'd recommend opening an issue in future first for a better experience all round, just so we can offer feedback on how worthwhile a change or addition is before you go ahead and raise a PR. Alternatively, you can take one of the issues that are already marked as help wanted.

Thank you again!

@subatoi subatoi closed this Sep 2, 2024
Copy link

@SonuG56 SonuG56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonuG56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authentication Content relating to authentication content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants