-
Notifications
You must be signed in to change notification settings - Fork 60k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update telling-git-about-your-signing-key.md #34401
Conversation
add alternative command for fish shell
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@alexmazaltov Thanks so much for opening a PR! I'll get this triaged for review ✨ |
@nguyenalex836 thank you for your time |
@nguyenalex836 please review |
Hi @alexmazaltov, and thanks for your submission and interest in the docs— As a rule, we target Bash. I think we can make that fact clearer in our contributing documentation and I'll discuss that internally. There are potentially many more places other than this one where we could add examples that are specific to other shells, and unless there's a very specific reason to call one out in particular, we wouldn't make an exception, so for that reason I'm afraid we won't be accepting this submission right now. I'd recommend opening an issue in future first for a better experience all round, just so we can offer feedback on how worthwhile a change or addition is before you go ahead and raise a PR. Alternatively, you can take one of the issues that are already marked as Thank you again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SonuG56
add alternative command for fish shell
Why: cause it is not obvious how to deal with gpg signature using fish shell
Closes:
What's being changed (if available, include any code snippets, screenshots, or gifs):
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.