Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dedicated reviewer teams in CODEOWNERS #53

Closed
qmonnet opened this issue Nov 29, 2024 · 0 comments · Fixed by #55
Closed

Use dedicated reviewer teams in CODEOWNERS #53

qmonnet opened this issue Nov 29, 2024 · 0 comments · Fixed by #55

Comments

@qmonnet
Copy link
Member

qmonnet commented Nov 29, 2024

Rather than having multiple people pulled for review for each PR, the docs/ repository could be owned by a GitHub team (to be created).

The advantages would be:

  • Avoid pulling all owners each time a PR is created. With automatic PR assignment, just one owner would be picked by the GitHub algorithm, balancing the review load, and keeping notifications low for other reviewers. Of course, if the PR owner feels like more eyes are necessary, it remains possible to manually assign more reviewers.
  • Draft Pull Requests don't get auto-assignment, meaning that nobody gets useless review notifications as long as the PR remains in draft state.

(Note: This is what we do for the dataplane repository, for an example.)

@qmonnet qmonnet mentioned this issue Dec 2, 2024
@qmonnet qmonnet linked a pull request Dec 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant