Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors in making #2

Open
Micalson opened this issue Jan 29, 2019 · 5 comments
Open

errors in making #2

Micalson opened this issue Jan 29, 2019 · 5 comments

Comments

@Micalson
Copy link

Hi, Thank you for your codes about sgm optimization. I got the following errors while making your codes.
"MC" : Undeclared identifier
"alignas": cannot find identifier
My environment is visual studio 2013, opencv3.0.0, and I configured the sse4.1 by including the header "smmintrin.h". In IDE, I could get the location of the error. See below.
default
( in file semi_global_matching.cpp)

Regards

@gishi523
Copy link
Owner

Hi, @Micalson

Thank you for your information.

The alignas specifier is supported from C++11.
Visual Studio 2013 doesn't fully support C++11, so it doesn't work.
If you want to use VS2013, try using __declspec(align(16)).

__declspec(align(16)) uchar MC[16];

Regards,
Gishi

@Micalson
Copy link
Author

Hi, @gishi523
Thank you for your reply.
I changed the file according to what you said, but the console showed same errors. So, could you tell me what your testing environment was?

Regards,
Micalson

@gishi523
Copy link
Owner

Hi, @Micalson
My testing environment are VS2015,VS2017, and Xubuntu 16.04.

@Micalson
Copy link
Author

Hi, @gishi523
I have tested it successfully in ubuntu 16.04, and it is really fast.
But I think you should try MI cost in the matching period, and you may get the better disparity.

Regards

@gishi523
Copy link
Owner

Hi, @Micalson

I'm glad that you could test it successfully.

But I think you should try MI cost in the matching period, and you may get the better disparity.

Thank you for your advice. I'm also interested in MI as matching cost.
Whereas, in this paper, the author says that

In general, Census is slightly inferior to MI, if there are only global radiometric differences, but it is much better for local radiometric changes, which are present in many real-world applications.

So, census may suffice as matching cost in general case.

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants