Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable opacity or make opacity in frame selector functional #1110

Closed
jeffbaumes opened this issue Apr 13, 2023 · 4 comments
Closed

Disable opacity or make opacity in frame selector functional #1110

jeffbaumes opened this issue Apr 13, 2023 · 4 comments
Assignees

Comments

@jeffbaumes
Copy link
Member

No description provided.

@manthey
Copy link
Member

manthey commented Apr 18, 2023

What exactly would this mean? Currently, we composite bands via either a maximum (for everything but alpha channels) or multiply (for alpha channels) effect. We currently render via JPG and have the tile layers stacked conceptually in the viewer so panning to an unloaded area will show a lower resolution until the higher resolution is loaded.

If you composite with an alpha channel, then we have to switch to rendering with PNG and only show the current tile layer (this is done when we do things like image overlays). For a single base image, this would let the background of the webpage show through, which probably isn't what is desired.

But, we could check if any band has a non unity opacity and switch to the single level/PNG rendering in that case. Until we do that, we should just disable selecting translucent colors.

@jeffbaumes jeffbaumes changed the title Enable opacity in frame selector Disable opacity or make opacity in frame selector functional Apr 18, 2023
@jeffbaumes
Copy link
Member Author

I do not know exactly what this would mean, but I believe we either disable opacity in the color selector or make it do something. I updated the issue title to reflect this.

@manthey
Copy link
Member

manthey commented Apr 18, 2023

@annehaley has disabled it in the color selector in #1086. We can revisit this later when desired.

@manthey
Copy link
Member

manthey commented Apr 20, 2023

Resolved in #1086.

@manthey manthey closed this as completed Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants