Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PVC should not be create for secret volumes #148

Open
WladyX opened this issue Oct 18, 2024 · 2 comments · May be fixed by #151
Open

PVC should not be create for secret volumes #148

WladyX opened this issue Oct 18, 2024 · 2 comments · May be fixed by #151

Comments

@WladyX
Copy link

WladyX commented Oct 18, 2024

similar on how PVCs ignore .existingConfigMap, think you should also add .existingSecret so that a PVC is not created for mounting a secret

davidfrickert added a commit to davidfrickert/onechart that referenced this issue Nov 20, 2024
@davidfrickert
Copy link
Contributor

Just had the same issue, i think PR #151 that I just published should fix it (plus bumping chart versions of course)

@davidfrickert
Copy link
Contributor

davidfrickert commented Nov 20, 2024

as a workaround until this fix is released, you can use the following workaround:

      volumes:
      - name: config
        path: /config/config.yml
        subPath: config.yml
        existingSecret: secret
        existingClaim: dummy

by using existingClaim to a dummy value, the pvc won't be created, and it won't be used at all because existingSecret is used for the mount as it has precedence in the template.

note: only tested that this works on the cron job chart, dont know if it works on the regular one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants