Skip to content
This repository has been archived by the owner on Oct 16, 2020. It is now read-only.

Delete node causes text-boxes to stop working #398

Open
PeterKottas opened this issue Jun 9, 2020 · 5 comments
Open

Delete node causes text-boxes to stop working #398

PeterKottas opened this issue Jun 9, 2020 · 5 comments
Labels
bug Something isn't working

Comments

@PeterKottas
Copy link

Describe the bug
Once you delete a node or a value, you will no longer be able to write in a new text-field (when creating new nodes or value)

To Reproduce
Steps to reproduce the behavior:

  1. Create node
  2. Delete node
  3. Create a new node and observe you can no longer write.

Expected behavior
It should work

Screenshots
If applicable, add screenshots to help explain your problem.

App version:
3.0.3

Desktop:

  • OS: Windows 10
@PeterKottas PeterKottas added the bug Something isn't working label Jun 9, 2020
@gilmarsquinelato
Copy link
Owner

Hey @PeterKottas,

I tested on this version with your steps and it didn't happen, could you record a small video or gif showing how you did it, please?

@PeterKottas
Copy link
Author

Sure thing, here you go: https://screencast-o-matic.com/watch/cY1IF9CtO4

@gilmarsquinelato
Copy link
Owner

It's really weird, on Mac OS it's not occurring, probably it's a Windows related problem.
Will need to investigate it.
Some solutions that came to my mind is to enforce the focus on the input every time that the dialog appears, and another one is to disable the "Ok" button when no text.

@PeterKottas
Copy link
Author

The form validation in regards to disabling ok button definitely makes sense. The autofocus is already implemented and I think that's what might be causing the issue. Maybe the component lifecycle is different on windows. If/when it works, it focuses the input automatically. However, when it's broken, there is no way to focus it at all. Mouse or keyboard. Therefore I think it has something to do with some sort of focus trap or the autofocus functionality.

@gilmarsquinelato
Copy link
Owner

Yep, it's weird, need some analysis on this bug.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants