fix: re-hide shorts on homepage #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shorts still appear in android Firefox. |
|
I was testing on chrome on macOS using the dev tools to emulate mobile. While I don’t have an android phone, I’ll test out my changes on Firefox as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #44, and closes #38.
This PR fixes hiding the shorts section on the YT homepage by removing the requirement that the 'Shorts' element be a descendant of an element with a
.reel-shelf-title-wrapperclass. From my investigation of the DOM it looks like the 'Shorts' heading no longer has an ancestor element that has a class of.reel-shelf-title-wrapper(see attached screenshot).Let me know if the filter isn't narrow enough and I'll look for elements that indicate that they're only used for shorts