From d0b9ebc9a03c13de4ea3a4c10b4be38b683f4c50 Mon Sep 17 00:00:00 2001 From: Spyros Synodinos Date: Fri, 11 Oct 2024 16:12:33 +0300 Subject: [PATCH 1/3] disable error message arround apps --- helm/teleport-kube-agent/templates/_config.tpl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/helm/teleport-kube-agent/templates/_config.tpl b/helm/teleport-kube-agent/templates/_config.tpl index 565e809..18a89a9 100644 --- a/helm/teleport-kube-agent/templates/_config.tpl +++ b/helm/teleport-kube-agent/templates/_config.tpl @@ -42,9 +42,9 @@ kubernetes_service: app_service: {{- if $appRolePresent }} - {{- if not (or (.Values.apps) (.Values.appResources) ($appDiscoveryEnabled)) }} - {{- fail "app service is enabled, but no application source is enabled. You must either statically define apps through `apps`, dynamically through `appResources`, or enable in-cluster discovery." }} - {{- end }} + #{{- if not (or (.Values.apps) (.Values.appResources) ($appDiscoveryEnabled)) }} + # {{- fail "app service is enabled, but no application source is enabled. You must either statically define apps through `apps`, dynamically through `appResources`, or enable in-cluster discovery." }} + #{{- end }} enabled: true {{- if .Values.apps }} {{- range $app := .Values.apps }} From 193f7c15f3be0d4f86d14f49b601c325c5df4fcc Mon Sep 17 00:00:00 2001 From: Spyros Synodinos Date: Fri, 11 Oct 2024 16:15:23 +0300 Subject: [PATCH 2/3] CHANGELOG --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index b511b1d..744ae96 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +### Changed + +- Disable chart-fail and error message if no apps set + ## [0.10.3] - 2024-09-26 ### Changed From c80a6866d7a43691e8df610245149fb4b2664d9b Mon Sep 17 00:00:00 2001 From: Franco Date: Mon, 14 Oct 2024 12:04:02 -0300 Subject: [PATCH 3/3] Remove error message when apps are enabled but no apps are defined --- helm/teleport-kube-agent/templates/_config.tpl | 3 --- 1 file changed, 3 deletions(-) diff --git a/helm/teleport-kube-agent/templates/_config.tpl b/helm/teleport-kube-agent/templates/_config.tpl index 18a89a9..a7b537d 100644 --- a/helm/teleport-kube-agent/templates/_config.tpl +++ b/helm/teleport-kube-agent/templates/_config.tpl @@ -42,9 +42,6 @@ kubernetes_service: app_service: {{- if $appRolePresent }} - #{{- if not (or (.Values.apps) (.Values.appResources) ($appDiscoveryEnabled)) }} - # {{- fail "app service is enabled, but no application source is enabled. You must either statically define apps through `apps`, dynamically through `appResources`, or enable in-cluster discovery." }} - #{{- end }} enabled: true {{- if .Values.apps }} {{- range $app := .Values.apps }}