Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAPA node draining - Phase 2 #2975

Open
1 of 2 tasks
Tracked by #2973
T-Kukawka opened this issue Nov 16, 2023 · 7 comments
Open
1 of 2 tasks
Tracked by #2973

CAPA node draining - Phase 2 #2975

T-Kukawka opened this issue Nov 16, 2023 · 7 comments
Labels
goal/capa-improvements provider/cluster-api-aws Cluster API based running on AWS team/phoenix Team Phoenix

Comments

@T-Kukawka
Copy link
Contributor

T-Kukawka commented Nov 16, 2023

Following Phase 1, after CAPA GA, we should investigate the usage of aws-node-termination-handler app for node draining once instances are being terminated via e.g. autoscaling. This with combination of "MachinePool Machines" feature in CAPA, CAPA logic should help to drain nodes within a pool, for example during an explicit ASG instance refresh.

Updated tasks list:

@T-Kukawka T-Kukawka added team/phoenix Team Phoenix provider/cluster-api-aws Cluster API based running on AWS labels Nov 16, 2023
@T-Kukawka
Copy link
Contributor Author

We have to investigate what are the solutions upstreams. The MachineDeployemnts has implementation for the handling of shutting down the nodes. There is no such solution for MachinePools. Before node shutdown we would have to receive the events from AWS to act upon them.

We have to follow up with upstream what is their plan for this.

@AndiDog
Copy link

AndiDog commented Nov 22, 2023

Maybe related:

Once the "MachinePool Machines" feature lands in CAPA, there's probably a better chance for CAPA logic to drain nodes within a pool, for example during an explicit ASG instance refresh.

@T-Kukawka
Copy link
Contributor Author

so it is not too far off with milestone 2.4

@T-Kukawka
Copy link
Contributor Author

Investigation feedback from older issue:
internal - #2170 (comment)
upstream - kubernetes-sigs/cluster-api#8348

@T-Kukawka
Copy link
Contributor Author

still blocked by: kubernetes-sigs/cluster-api-provider-aws#4184

@T-Kukawka
Copy link
Contributor Author

@AndiDog will try to give it a nudge

@T-Kukawka
Copy link
Contributor Author

additional solution besides the health checks: https://github.com/giantswarm/giantswarm/issues/31843

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal/capa-improvements provider/cluster-api-aws Cluster API based running on AWS team/phoenix Team Phoenix
Projects
Status: Inbox 📥
Development

No branches or pull requests

2 participants