-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAPA node draining - Phase 2 #2975
Comments
We have to investigate what are the solutions upstreams. The MachineDeployemnts has implementation for the handling of shutting down the nodes. There is no such solution for MachinePools. Before node shutdown we would have to receive the events from AWS to act upon them. We have to follow up with upstream what is their plan for this. |
Maybe related:
Once the "MachinePool Machines" feature lands in CAPA, there's probably a better chance for CAPA logic to drain nodes within a pool, for example during an explicit ASG instance refresh. |
so it is not too far off with milestone 2.4 |
Investigation feedback from older issue: |
still blocked by: kubernetes-sigs/cluster-api-provider-aws#4184 |
@AndiDog will try to give it a nudge |
additional solution besides the health checks: https://github.com/giantswarm/giantswarm/issues/31843 |
Following Phase 1, after CAPA GA, we should investigate the usage of
aws-node-termination-handler app
for node draining once instances are being terminated via e.g. autoscaling. This with combination of "MachinePool Machines" feature in CAPA, CAPA logic should help to drain nodes within a pool, for example during an explicit ASG instance refresh.Updated tasks list:
The text was updated successfully, but these errors were encountered: