-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically add OIDC flags to API server when Auth-bundle is installed #3550
Comments
Dex operator will be extended to patch the WC resources and add the OIDC flags unless they already exist. |
This feature will only be available in CAPI clusters. Dex operator will check the KubeadmControlPlane CR to find out if the OIDC flags have already been set. Once the new cluster configuration is accepted and applied, the CP nodes are rolled automatically. Also, the implementation will cover this ticket and #3551. |
Added support for a new |
Adding the flags works as expected now. When the Dex app is deleted from the cluster, the OIDC flags configured in the Kubeadm COntrol Plane will no longer be valid. However, if they are removed from the cluster, control plane nodes will be rolled, which may not always be desirable. So, question is - in case Dex operator takes care of adding the OIDC flags to the cluster, can it also take care of their deletion when the Dex app is deleted? Or is it safer to keep the OIDC flags in the cluster and rely on the user to remove them manually? |
Adding OIDC flags may be tricky because they need to be applied to the cluster app. The preferred way to configure clusters is via gitops, which means that the source of truth for all configuration is/should be on the customer's side. If we make modifications to the cluster configuration on our side, it may be overwritten by the next change introduced by the customer. And even if it isn't, t may still create conflicts with the customer configuration. Updating OIDC flags automatically is still considered somewhat valuable. It was suggested that we expose a flag in the cluster app configuration, and if it's enabled, the Auth bundle would be installed when the cluster is created and OIDC flags would be set. |
Closing this issue since automating the OIDC flags addition/removal by using Dex operator to modify the Cluster app configuration is not considered safe or desirable. The alternative approach suggested above will be explored and a new issue will be created for it. |
Implement functionality to fulfil the following requirement:
The text was updated successfully, but these errors were encountered: