Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] [themes]: Dracula Theme Color Scheme not respected #3441

Closed
Bellisario opened this issue Dec 27, 2024 · 5 comments
Closed

[bug] [themes]: Dracula Theme Color Scheme not respected #3441

Bellisario opened this issue Dec 27, 2024 · 5 comments

Comments

@Bellisario
Copy link

Bellisario commented Dec 27, 2024

TL;DR

The current built-in Dracula theme doesn't respect the official Dracula scheme, uses different colors and is missing light-versions of colors (reusing "non-light" versions), presenting contrast issues.

What I've experienced

I have just installed Ghostty and I chose to use the Dracula color scheme, as I did with Kitty.
Just after the first seconds I tried using zsh-autosuggestions but saw the autocompletion color in Ghostty was different than the one in Kitty (and the one in Ghostty had really low contrast with the background).

Kitty (left) vs Ghostty (right):
Image

After investigating a bit, I discovered that the colors used by Kitty's Dracula theme are (mostly) different in Ghostty. For example, the autocompletion color used is the "8th color", which is #6272a4 for Kitty, while #555555 for Ghostty.

Anyway, I'm certain the "wrong" color scheme is Ghostty's because Kitty uses the color scheme from the official Dracula (org) repo, while Ghostty seems to use iTerm 2 "unofficial" theme.

Here are the (comparable) schemes used by Kitty and Ghostty, respectively (from the links above):

Light versions of colors are completely reused from non-light ones, some colors are different from the ones used by Kitty (ex. background)

Kitty Ghostty
foreground            #f8f8f2
background            #282a36
selection_foreground  #ffffff
selection_background  #44475a

# black
color0  #21222c
color8  #6272a4

# red
color1  #ff5555
color9  #ff6e6e

# green
color2  #50fa7b
color10 #69ff94

# yellow
color3  #f1fa8c
color11 #ffffa5

# blue
color4  #bd93f9
color12 #d6acff

# magenta
color5  #ff79c6
color13 #ff92df

# cyan
color6  #8be9fd
color14 #a4ffff

# white
color7  #f8f8f2
color15 #ffffff

# Cursor colors
cursor            #f8f8f2
cursor_text_color background
foreground = #f8f8f2
background = #1e1f29
selection-foreground = #ffffff
selection-background = #44475a

# black
palette = 0=#000000
palette = 8=#555555

# red
palette = 1=#ff5555
palette = 9=#ff5555

# green
palette = 2=#50fa7b
palette = 10=#50fa7b

# yellow
palette = 3=#f1fa8c
palette = 11=#f1fa8c

# blue
palette = 4=#bd93f9
palette = 12=#bd93f9

# magenta
palette = 5=#ff79c6
palette = 13=#ff79c6

# cyan
palette = 6=#8be9fd
palette = 14=#8be9fd

# white
palette = 7=#bbbbbb
palette = 15=#ffffff

cursor-color = #bbbbbb


Haven't looked at other themes but I hope they respect the original theme scheme... in my case the only flaw of migrating from Kitty to Ghostty was just the theme.

Throughts

From what I've experienced, I really liked the way Ghostty let you choose a theme, but what I really feel missing is support of official themes (ex. Dracula, Cappuccin), that should be in the "Ghostty org" or in the "theme org", not a "third-party org".

@mitchellh
Copy link
Contributor

Upstream: https://iterm2colorschemes.com

@Gelmo
Copy link

Gelmo commented Dec 30, 2024

Just posted about this here - mbadolato/iTerm2-Color-Schemes#487

@Gelmo
Copy link

Gelmo commented Dec 30, 2024

@Bellisario @mitchellh This has now been resolved upstream, if you want to run that workflow manually

@mitchellh
Copy link
Contributor

Thanks, I'll do so before the next release, otherwise the weekly job will get it.

@Gelmo
Copy link

Gelmo commented Jan 2, 2025

Now that I've tested this, it unfortunately is not resolved. More info here - mbadolato/iTerm2-Color-Schemes#490 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants