Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"stop" only kills 1 of three monitors #25

Open
JayRugMan opened this issue Feb 20, 2023 · 3 comments
Open

"stop" only kills 1 of three monitors #25

JayRugMan opened this issue Feb 20, 2023 · 3 comments

Comments

@JayRugMan
Copy link

JayRugMan commented Feb 20, 2023

Setup:

OS: Linux Mint 21.1 x86_64
Host: Dell G15 5520
Kernel: 5.15.0-60-generic
Resolution: 1920x1080
DE: Cinnamon 5.6.7
WM: Mutter (Muffin)
WM Theme: Numix-Cinnamon-Transparent (Mint-Y)
Theme: Adapta-Nokto [GTK2/3]
Icons: Mint-Y-Aqua [GTK2/3]
CPU: 12th Gen Intel i5-12500H (16) @ 4.500GHz
GPU: NVIDIA GeForce RTX 3050 Mobile
GPU: Intel Alder Lake-P
Memory: 2700MiB / 31789MiB

Issue and solution

When, either in the GUI or from the command line, if I start the application I get it running on all three monitors, however, stop will only kill it on one. I took a look at the code and found that one PID was stored in the settings file. I created a branch and fixed the code to store the PIDS in an array and made the stop function iterate over the array to kill multiple PIDS - It will even store and source the array successfully in the settings file. I also restructured the bash code to flow a little more easily, added the use of GNU getop, and modified the python script accordingly. I have the code committed locally on the new branch and just need permission to submit a pull request.

Request

Let me know if you're interested in my modifications and I'll send you my public key so I can set my branch upstream.

@JayRugMan JayRugMan changed the title only kills 1 of three monitors "stop" only kills 1 of three monitors Feb 20, 2023
@JayRugMan
Copy link
Author

Is anyone still looking at these issues? I have a branch of this repo I'd like to have reviewed and merged that fixes this issue, as well as some other issues like multiple PID handling and an more elegant way of reading the config file. Let me know if you'd like to take a look and let me merge.

@JayRugMan
Copy link
Author

Guess I'm forking

@ghostlexly
Copy link
Owner

I'm still looking at the issues
I have leaved a comment on your PR, can you check it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants