Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOTV: Zerg macro doesn't work when queuing injects #50

Open
gravelweb opened this issue Jun 5, 2016 · 2 comments
Open

LOTV: Zerg macro doesn't work when queuing injects #50

gravelweb opened this issue Jun 5, 2016 · 2 comments

Comments

@gravelweb
Copy link

gravelweb commented Jun 5, 2016

Looks like queueing injects causes the previous inject to be unregistered.

sc2parse/plugins.py:1153 (ZergMacroTracker)

        if target_hatch_id not in owner.hatches:
            target_hatch.injects = [event.frame]
            owner.hatches[target_hatch_id] = target_hatch
        else:
            # If not enough time has passed, the last one didn't happen
            if event.frame - target_hatch.injects[-1] < INJECT_TIME:
                print "Previous inject on {0} at {1} failed".format(target_hatch, target_hatch.injects[-1])
                target_hatch.injects[-1] = event.frame
            else:
                target_hatch.injects.append(event.frame)
@dsjoerg
Copy link
Member

dsjoerg commented Jun 13, 2016

Fixed by ggtracker/sc2reader#14 and dsjoerg/ggpyjobs#11

@dsjoerg dsjoerg closed this as completed Jun 13, 2016
@gravelweb
Copy link
Author

The queued injects are still not showing up in the graph, because of the code above ^^ I'm looking to solve this in the beginning of July.

@dsjoerg dsjoerg reopened this Jun 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants