Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show supply cap times #33

Open
dsjoerg opened this issue Apr 18, 2016 · 3 comments
Open

Show supply cap times #33

dsjoerg opened this issue Apr 18, 2016 · 3 comments

Comments

@dsjoerg
Copy link
Member

dsjoerg commented Apr 18, 2016

From @toff63 on August 19, 2014 19:33

Nicely show the periods when the play was supply cap and the total time during the game he was supply cap. This is a basic mistake for beginner. Fixing this issue will help player to improve

Copied from original issue: dsjoerg/ggtracker#9

@dsjoerg
Copy link
Member Author

dsjoerg commented Apr 18, 2016

good idea, that is a popular request and may be a reasonable one for someone new to the codebase.

as far as how to show it — one way would be to add a new graph to the bottom section that shows both players total supply. on that chart, instead of highlighting combat periods, we could highlight the supply-blocked periods.

alternatively, there could be a per-user option to choose whether they want supply blocks, combat or both highlighted on the main chart.

@dsjoerg
Copy link
Member Author

dsjoerg commented Apr 18, 2016

By the way, if anyone wants to work on this, have a look at https://github.com/dsjoerg/ggpyjobs/blob/master/sc2parse/sc2reader_to_esdb.py#L196

That's where we walk through the tracker_events and pick out the PlayerStatsEvents.

@dsjoerg
Copy link
Member Author

dsjoerg commented Apr 18, 2016

Or if you want a finer-grained look at whether a player is supply capped, you could walk through the finer-grained events of unit and building births and deaths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant