wgpu-core: Only produce StageError::InputNotConsumed on DX11/DX12 #4116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaron1011
force-pushed
the
consume-output-dx-only
branch
from
8b5f328 to
6cfd34e
Compare
|
This is a pretty big portability hazard. If we wanted to do this, we would need to surface it as a feature that users can enable, knowing they are opting into behavior that is not portable to D3D. I would personally prefer if this was just fixed in naga, but a feature would be an acceptable interim solution. |
|
Marked the PR as draft to reflect that Connor requested some changes to be made before it can be merged. |
nical
requested changes
Sep 14, 2023
Aaron1011
force-pushed
the
consume-output-dx-only
branch
from
da0c51d to
b002299
Compare
nical
approved these changes
Sep 20, 2023
|
Looks ready once the merge conflict in wgpu-types/src/lib.rs is resolved. |
This error only exists due to an issue with naga's HLSL support: gfx-rs/naga#1945 The WGPU spec itself allows vertex shader outputs that are not consumed by the fragment shader. Until the issue is fixed, we can allow unconsumed outputs on all platforms other than DX11/DX12.
Aaron1011
force-pushed
the
consume-output-dx-only
branch
from
b002299 to
c31d0bc
Compare
|
I fixed the merge conflict - I had to pick a different id for the feature |
Aaron1011
added a commit
to ruffle-rs/wgpu
that referenced
this pull request
Sep 30, 2023
…x-rs#4116) * wgpu-core: Only produce StageError::InputNotConsumed on DX11/DX12 This error only exists due to an issue with naga's HLSL support: gfx-rs/naga#1945 The WGPU spec itself allows vertex shader outputs that are not consumed by the fragment shader. Until the issue is fixed, we can allow unconsumed outputs on all platforms other than DX11/DX12. * Add Features::SHADER_UNUSED_VERTEX_OUTPUT to allow disabling check * Pick an unused feature id
torokati44
pushed a commit
to torokati44/wgpu
that referenced
this pull request
Oct 9, 2023
…x-rs#4116) * wgpu-core: Only produce StageError::InputNotConsumed on DX11/DX12 This error only exists due to an issue with naga's HLSL support: gfx-rs/naga#1945 The WGPU spec itself allows vertex shader outputs that are not consumed by the fragment shader. Until the issue is fixed, we can allow unconsumed outputs on all platforms other than DX11/DX12. * Add Features::SHADER_UNUSED_VERTEX_OUTPUT to allow disabling check * Pick an unused feature id
|
Would it be possible to get this backported to the v0.17 branch, please? And perhaps get a new release with it in somewhat soon-ish? |
torokati44
pushed a commit
to torokati44/wgpu
that referenced
this pull request
Oct 9, 2023
…x-rs#4116) * wgpu-core: Only produce StageError::InputNotConsumed on DX11/DX12 This error only exists due to an issue with naga's HLSL support: gfx-rs/naga#1945 The WGPU spec itself allows vertex shader outputs that are not consumed by the fragment shader. Until the issue is fixed, we can allow unconsumed outputs on all platforms other than DX11/DX12. * Add Features::SHADER_UNUSED_VERTEX_OUTPUT to allow disabling check * Pick an unused feature id
torokati44
reviewed
Oct 10, 2023
| /// - Metal | ||
| /// - OpenGL | ||
| const SHADER_UNUSED_VERTEX_OUTPUT = 1 << 54; | ||
|
|
||
| // 54..59 available |
There was a problem hiding this comment.
Just noticed, this line did not get updated.
torokati44
pushed a commit
to torokati44/wgpu
that referenced
this pull request
Oct 10, 2023
…x-rs#4116) * wgpu-core: Only produce StageError::InputNotConsumed on DX11/DX12 This error only exists due to an issue with naga's HLSL support: gfx-rs/naga#1945 The WGPU spec itself allows vertex shader outputs that are not consumed by the fragment shader. Until the issue is fixed, we can allow unconsumed outputs on all platforms other than DX11/DX12. * Add Features::SHADER_UNUSED_VERTEX_OUTPUT to allow disabling check * Pick an unused feature id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Description
This error only exists due to an issue with naga's HLSL support:
The WGPU spec itself allows vertex shader outputs that are not consumed by the fragment shader.
Until the issue is fixed, we can allow unconsumed outputs on all platforms other than DX11/DX12.
Testing
Run a program with an unconsumed shader output on a non-DX backend, and note the lack of error.