Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start-capture (and probably stop-capture) are unsound #1625

Open
pythonesque opened this issue Jul 10, 2021 · 1 comment
Open

start-capture (and probably stop-capture) are unsound #1625

pythonesque opened this issue Jul 10, 2021 · 1 comment
Labels
area: validation Issues related to validation, diagnostics, and error handling help required We need community help to make this happen. type: bug Something isn't working

Comments

@pythonesque
Copy link
Contributor

Description
Currently, wgpu-core (effectively) just calls start-capture on the raw underlying device without performing any checks.

From @kvark

we could document the safety requirements for start_capture as:

  1. device should be a valid device that's not lost
  2. no capture needs to be already in progress

Device loss is covered #1624. The start/stop capture thing is a separate issue that is probably more straightforward to fix.

@cwfitzgerald cwfitzgerald added area: validation Issues related to validation, diagnostics, and error handling help required We need community help to make this happen. type: bug Something isn't working labels Jul 10, 2021
@teoxoy
Copy link
Member

teoxoy commented Aug 9, 2024

57f8757 (#4163) added device validity checks for start/stop capture.

But we still don't validate if a capture in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: validation Issues related to validation, diagnostics, and error handling help required We need community help to make this happen. type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants