clojure-test: Exception report is not readable

[frenchy64]

Problem: when an exception occurs in checking, the resulting exception is not presented to the user in a readable format.

I believe the final argument to is needs a pr-str to print correctly here.

Without a pr-str, data like "" and nil print as nothing.

;; without pr-str
(clojure.test/is nil (ex-info "foo" {:a ""}))
;; FAIL in () (form-init9996546679642775017.clj:42)
;; #error {
;;  :cause foo
;;  :data {:a }
;;  :via
;;  [{:type clojure.lang.ExceptionInfo
;;    :message foo
;;    :data {:a }

;; with pr-str
(clojure.test/is nil (pr-str (ex-info "foo" {:a ""})))
;; FAIL in () (form-init9996546679642775017.clj:43)
;; #error {
;;  :cause "foo"
;;  :data {:a ""}
;;  :via
;;  [{:type clojure.lang.ExceptionInfo
;;    :message "foo"
;;    :data {:a ""}

[gfredericks]

Thenot-exception? part of the (is (not-exception? (:result result)) result) line makes me wonder if this could/should be simplified by using the new test.check key[s] that describe pass/fail using a boolean rather than the more ambiguous value-or-exception logic.

Anyhow, that's probably orthogonal to what's being pointed out here?

I have the vague notion that the second arg to is is supposed to be a string regardless, so in that respect your suggestion seems straightforwardly correct.

[frenchy64]

... using the new test.check key[s] that describe pass/fail using a boolean rather than the more ambiguous value-or-exception logic.

Ah, yes. That behavior sounds much better. Orthogonal, but better. Opened #68.

This issue title more describes a fix than the problem. The problem is that the error report is not readable data, since "" and nil and such are lost. One fix is to use pr-str to report the exception. Another might be to find a prettier but also readable way to report this exception.