V2 #230
Merged
V2 #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pyproject.toml # src/zep_cloud/core/client_wrapper.py
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to da4fbc1 in 43 seconds
More details
- Looked at
375lines of code in9files - Skipped
0files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. src/zep_cloud/group/client.py:41
- Draft comment:
Thegroup_idparameter is now a requiredstr, notOptional[str]. Update the docstring to reflect this change. - Reason this comment was not posted:
Comment looked like it was already resolved.
2. src/zep_cloud/group/client.py:161
- Draft comment:
Thegroup_idparameter is now a requiredstr, notOptional[str]. Update the docstring to reflect this change. - Reason this comment was not posted:
Marked as duplicate.
3. src/zep_cloud/memory/client.py:947
- Draft comment:
The docstring for theaddmethod should end with a period for consistency. This applies to both the synchronous and asynchronous versions of the method.
Add memory to the specified session.
- Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_HtPiLjtU5RKPZv6a
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Introduced
ApidataAddMemoryResponsefor memory handling, updatedgroup_idrequirement ingroup/client.py, and version to 2.2.0.ApidataAddMemoryResponseinmemory/client.pyfor handling memory addition responses.addmethod ingroup/client.pyto requiregroup_idparameter.pyproject.tomlandclient_wrapper.py.ApidataAddMemoryResponseclass inapidata_add_memory_response.py.fact_rating_instructiontoUserclass inuser.py.graph/client.pyforsearchmethod.This description was created by
for da4fbc1. It will automatically update as commits are pushed.