Prevent reparenting a tag to itself #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sidebar.check_parent now checks if the drop target is the same tag we are moving.
diegogangl
added this to the 0.7: "Getting things Gradius — Destroy the core!" milestone
|
Merged, thanks!
Sure, the only plan right now is to stabilize and release 0.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to PR #1149, it was possible to reparent a tag to itself using drag-and-drop.
Sidebar.check_parentnow checks if the drop target is the same tag we are moving.Steps to reproduce the bug:
(If it is not against any current plans, I would be happy to experiment with a common
StoreItembase class or something similar to prevent such duplicated bugs.)