From a56852b4ce4d9237321f173c23759c5e48522433 Mon Sep 17 00:00:00 2001 From: Sebastian Zivota Date: Wed, 23 Oct 2024 14:17:11 +0200 Subject: [PATCH] fix: Don't log entire S3 error as part of the message (#1542) --- crates/symbolicator-service/src/download/s3.rs | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/crates/symbolicator-service/src/download/s3.rs b/crates/symbolicator-service/src/download/s3.rs index 2706d8711..ee9dec99e 100644 --- a/crates/symbolicator-service/src/download/s3.rs +++ b/crates/symbolicator-service/src/download/s3.rs @@ -130,8 +130,7 @@ impl S3Downloader { // of these in production and figure out what we actually get here tracing::error!( error = &err as &dyn std::error::Error, - "S3 request timed out: {:?}", - err + "S3 request timed out", ); return Err(CacheError::Timeout(Duration::ZERO)); } @@ -169,7 +168,7 @@ impl S3Downloader { tracing::error!( error = &err as &dyn std::error::Error, "S3 request failed: {:?}", - err + err.code(), ); let details = err.to_string(); Err(CacheError::DownloadError(details)) @@ -179,7 +178,7 @@ impl S3Downloader { }; if response.content_length == Some(0) { - tracing::debug!("Empty response from s3:{}{}", &bucket, &key); + tracing::debug!(bucket, key, "Empty response from s3"); return Err(CacheError::NotFound); }