diff --git a/CHANGELOG.md b/CHANGELOG.md index 67677a00e..216cdf7e0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,7 @@ ### Various fixes & improvements +- Transaction sample rate is now configurable through the config file ([#1517](https://github.com/getsentry/symbolicator/pull/1517)). - In native symbolication, trying to download a source file from a sourcelink now creates a candidate ([#1507](https://github.com/getsentry/symbolicator/pull/1510)). diff --git a/crates/symbolicator-service/src/config.rs b/crates/symbolicator-service/src/config.rs index d7b6d6bf4..eb6b72028 100644 --- a/crates/symbolicator-service/src/config.rs +++ b/crates/symbolicator-service/src/config.rs @@ -559,6 +559,15 @@ impl Default for Config { max_concurrent_requests: Some(200), shared_cache: None, _crash_db: None, + // Symbolicator receives at peak: + // - ~3_000 `symbolicate_js`, + // - ~800 `symbolicater`, and + // - ~40 `minidump_stackwalk` requests per second. + // + // round that up to ~4_000 total requests per second, with a 5% sample rate, + // we end up with ~200 sampled transactions per second, or ~12_000 per minute. + // We only do this for the "real" transactions and not the http frontend that + // just spawns these computations. transaction_sample_rate: 0.05, } } diff --git a/crates/symbolicator/src/cli.rs b/crates/symbolicator/src/cli.rs index f0a17ed14..fd4555194 100644 --- a/crates/symbolicator/src/cli.rs +++ b/crates/symbolicator/src/cli.rs @@ -91,17 +91,6 @@ pub fn execute() -> Result<()> { if Some(true) == ctx.sampled() { 1.0 } else if ctx.operation() != "http.server" { - // TODO: Think about what to do with this comment now: - // Symbolicator receives at peak: - // - ~3_000 `symbolicate_js`, - // - ~800 `symbolicater`, and - // - ~40 `minidump_stackwalk` requests per second. - // - // round that up to ~4_000 total requests per second, with a 5% sample rate, - // we end up with ~200 sampled transactions per second, or ~12_000 per minute. - // We only do this for the "real" transactions and not the http frontend that - // just spawns these computations. - config.transaction_sample_rate } else { 0.0