From 4ae4745adbac74eb07a4c6a0c85f46ce14b4b45f Mon Sep 17 00:00:00 2001 From: Arpad Borsos Date: Fri, 16 Feb 2024 13:12:58 +0100 Subject: [PATCH] Increase percentage of sampled transactions (#1376) --- crates/symbolicator/src/cli.rs | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/crates/symbolicator/src/cli.rs b/crates/symbolicator/src/cli.rs index 1c32c3266..9550e4c83 100644 --- a/crates/symbolicator/src/cli.rs +++ b/crates/symbolicator/src/cli.rs @@ -91,14 +91,16 @@ pub fn execute() -> Result<()> { if Some(true) == ctx.sampled() { 1.0 } else if ctx.operation() != "http.server" { - // Symbolicator receives ~200 rps right now, - // with ~20 sampled transactions per minute, - // which comes to an effective sampling rate of `1/600` (~0.0016). - // Lets crank that up to `0.02`, which would give us ~4 rps, - // or ~240 transactions per minute. + // Symbolicator receives at peak: + // - ~3_000 `symbolicate_js`, + // - ~800 `symbolicater`, and + // - ~40 `minidump_stackwalk` requests per second. + // + // round that up to ~4_000 total requests per second, with a 5% sample rate, + // we end up with ~200 sampled transactions per second, or ~12_000 per minute. // We only do this for the "real" transactions and not the http frontend that // just spawns these computations. - 0.02 + 0.05 } else { 0.0 }