Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing mangling in stack trace #873

Open
sindresorhus opened this issue Oct 17, 2024 · 5 comments
Open

Missing mangling in stack trace #873

sindresorhus opened this issue Oct 17, 2024 · 5 comments

Comments

@sindresorhus
Copy link

Platform

macOS

Environment

Production

Installed

Swift Package Manager

Version

8.38.0

Xcode Version

16.0

Did it work on previous versions?

No response

Steps to Reproduce

One stack frame is not demangled:

$s11Supercharge2AXO7ElementPAAE8elements33_35EDDAA799FBB5B74D2F426690B0D99DLL3for2asSayqd__GSo28NSAccessibilityAttributeNamea_qd__mtSo7AXErrorVYKAcDRd__lFAC3AppC_AC6WindowCTgm5

The stack trace line number referes to try value(for: attribute, as: [AXUIElement].self)?.map { T($0) } ?? [] in

enum AX {}

extension AX {
	protocol Element {}
}

extension AXError: @retroactive Error {}

extension AX.Element {
	fileprivate func elements<T: AX.Element>(
		for attribute: NSAccessibility.Attribute,
		as type: T.Type
	) throws(AXError) -> [T] {
		try value(for: attribute, as: [AXUIElement].self)?.map { T($0) } ?? []
	}
}

So it could be missing handling of mangling for nested protocols or typed throws.

Expected Result

I expected the stack frames be properly demangled.

Actual Result

Stack trace: https://sindresorhus.sentry.io/share/issue/784ced2af05b481d864831afb7c66548/

Are you willing to submit a PR?

No response

@philipphofmann
Copy link
Member

philipphofmann commented Oct 17, 2024

This looks more like a problem with symbolication. I'm going to transfer this issue to the main repo. This could be related to getsentry/sentry#79268.

@philipphofmann philipphofmann transferred this issue from getsentry/sentry-cocoa Oct 17, 2024
@getsantry
Copy link

getsantry bot commented Oct 17, 2024

Auto-routing to @getsentry/product-owners-issues for triage ⏲️

@getsantry
Copy link

getsantry bot commented Oct 17, 2024

Routing to @getsentry/product-owners-issues-source-maps for triage ⏲️

@getsantry
Copy link

getsantry bot commented Oct 21, 2024

Routing to @getsentry/product-owners-processing for triage ⏲️

@loewenheim loewenheim transferred this issue from getsentry/sentry Oct 22, 2024
@loewenheim
Copy link
Contributor

Indeed, the current swift demangler in symbolic cannot demangle this symbol. It's possible that #854 would help, but that has stalled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

3 participants