From 8231446579c436a95d0f645b5b7a646445e1f646 Mon Sep 17 00:00:00 2001 From: Arpad Borsos Date: Mon, 23 Oct 2023 14:29:19 +0200 Subject: [PATCH] lints and test fix --- CHANGELOG.md | 4 ++++ py/tests/test_proguard.py | 11 +++++------ 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index fb9eb9f8..b4e1e4b2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,10 @@ - Emit a MODULE record for PE files ([#814](https://github.com/getsentry/symbolic/pull/814)) +**Features** + +- Update proguard and add `remap_method` fn ([#818](https://github.com/getsentry/symbolic/pull/818)) + ## 12.4.1 **Fixes** diff --git a/py/tests/test_proguard.py b/py/tests/test_proguard.py index 3d7eac59..1b92d6b3 100644 --- a/py/tests/test_proguard.py +++ b/py/tests/test_proguard.py @@ -13,6 +13,11 @@ def test_mapper(res_path): == "android.support.constraint.ConstraintLayout$LayoutParams" ) + assert mapper.remap_method("android.support.constraint.a.b", "f") == ( + "android.support.constraint.solver.ArrayRow", + "pickRowVariable", + ) + remapped = mapper.remap_frame("android.support.constraint.a.b", "a", 116) assert len(remapped) == 1 assert remapped[0].class_name == "android.support.constraint.solver.ArrayRow" @@ -27,9 +32,3 @@ def test_mapper(res_path): assert remapped[1].line == 44 assert remapped[2].method == "onClickHandler" assert remapped[2].line == 40 - - remapped = mapper.remap_method("android.support.constraint.a.b", "f") - assert remapped == ( - "android.support.constraint.solver.ArrayRow", - "void pickRowVariable()", - )