fix(eap): Handle nans in other timeseries for EAP #82131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the nans in the other timeseries for EAP when some numeric attribute does not exist for a time bucket, the avg aggregate will produce a nan. It does not fix it for the spans indexed dataset because the query there is actually wrong and treats entries without the attribute as 0. It also does not fix it for the rpc calls because rpc calls are failing with a division by 0 error.
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #82131 +/- ##
==========================================
+ Coverage 80.28% 80.37% +0.08%
==========================================
Files 7506 7277 -229
Lines 331637 321496 -10141
Branches 20966 20966
==========================================
- Hits 266252 258398 -7854
+ Misses 64977 62690 -2287
Partials 408 408 |
wmak
approved these changes
Dec 16, 2024
Zylphrex
deleted the
txiao/fix/handle-nans-in-other-timeseries-for-eap
branch
evanh
pushed a commit
that referenced
this pull request
Dec 17, 2024
This fixes the nans in the other timeseries for EAP when some numeric attribute does not exist for a time bucket, the avg aggregate will produce a nan. It does not fix it for the spans indexed dataset because the query there is actually wrong and treats entries without the attribute as 0. It also does not fix it for the rpc calls because rpc calls are failing with a division by 0 error.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the nans in the other timeseries for EAP when some numeric attribute does not exist for a time bucket, the avg aggregate will produce a nan. It does not fix it for the spans indexed dataset because the query there is actually wrong and treats entries without the attribute as 0. It also does not fix it for the rpc calls because rpc calls are failing with a division by 0 error.