Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: avoid clobbering APIView.handle_exception #81673

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

asottile-sentry
Copy link
Member

No description provided.

@asottile-sentry asottile-sentry requested review from a team December 4, 2024 18:03
@asottile-sentry asottile-sentry requested review from a team as code owners December 4, 2024 18:03
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...sentry/integrations/jira/webhooks/issue_updated.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #81673   +/-   ##
=======================================
  Coverage   80.44%   80.44%           
=======================================
  Files        7245     7245           
  Lines      321760   321760           
  Branches    20827    20827           
=======================================
  Hits       258854   258854           
  Misses      62507    62507           
  Partials      399      399           

@asottile-sentry asottile-sentry merged commit 9233647 into master Dec 4, 2024
50 checks passed
@asottile-sentry asottile-sentry deleted the asottile-dont-clobber-handle-exception branch December 4, 2024 18:34
Copy link

sentry-io bot commented Dec 4, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ValidationError: '“%(value)s” is not a valid UUID.' /api/0/projects/{organization_id_or_slug}/{proj... View Issue
  • ‼️ ValidationError: Invalid response format for SelectField in rootly from uri: /webhooks/incoming/sentry_webhooks/no... sentry.api.sentry_app_components.get View Issue
  • ‼️ OperationalError: QueryCanceled('canceling statement due to user request\n') /api/0/organizations/{organization_id_or_slug}/... View Issue
  • ‼️ HTTPError: 500 Server Error: Internal Server Error for url: http://seer-autofix/v1/automation/summarize/issue /api/0/organizations/{organization_id_or_slug}/... View Issue
  • ‼️ SnubaRPCError: code: 500 /api/0/organizations/{organization_id_or_slug}/... View Issue

Did you find this useful? React with a 👍 or 👎

ffelixg added a commit to ffelixg/sentry that referenced this pull request Dec 18, 2024
andrewshie-sentry pushed a commit that referenced this pull request Jan 2, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants