Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(new-trace): Making trace project slugs unique #81435

Merged
merged 1 commit into from
Nov 29, 2024
Merged

fix(new-trace): Making trace project slugs unique #81435

merged 1 commit into from
Nov 29, 2024

Conversation

Abdkhan14
Copy link
Contributor

Screenshot 2024-11-28 at 2 21 46 PM

@Abdkhan14 Abdkhan14 requested a review from a team as a code owner November 28, 2024 19:22
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 28, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ceDetails/traceTypeWarnings/errorsOnlyWarnings.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #81435      +/-   ##
==========================================
- Coverage   80.38%   80.38%   -0.01%     
==========================================
  Files        7224     7224              
  Lines      319402   319403       +1     
  Branches    20747    20749       +2     
==========================================
  Hits       256742   256742              
- Misses      62267    62268       +1     
  Partials      393      393

@Abdkhan14 Abdkhan14 merged commit 8c372c8 into master Nov 29, 2024
45 checks passed
@Abdkhan14 Abdkhan14 deleted the abdk/trace-header-projects branch November 29, 2024 17:04
andrewshie-sentry pushed a commit that referenced this pull request Dec 2, 2024
@Abdkhan14 @andrewshie-sentry
fix(new-trace): Making trace project slugs unique (#81435)
7a4a552 
<img width="344" alt="Screenshot 2024-11-28 at 2 21 46 PM"
src="https://github.com/user-attachments/assets/c4941a45-cd25-430d-aaa5-aaa320241fb5">

Co-authored-by: Abdullah Khan <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JonasBa JonasBa JonasBa approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Abdkhan14 @JonasBa