Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auth] ?redirect query param is lost after complex sso login workflow #79130

Closed
ryan953 opened this issue Oct 15, 2024 · 3 comments
Closed

[Auth] ?redirect query param is lost after complex sso login workflow #79130

ryan953 opened this issue Oct 15, 2024 · 3 comments
Labels

Comments

@ryan953
Copy link
Member

ryan953 commented Oct 15, 2024

Sometimes when logging in with a ?redirect= query param, the redirect is 'lost' and the user ends up on the /issues page instead of where they're trying to go.

@ryan953
Copy link
Member Author

ryan953 commented Oct 15, 2024

cc @leedongwei @cathteng

@ryan953
Copy link
Member Author

ryan953 commented Oct 15, 2024

Sat with @cathteng, the problem seems to happen when the requested url contains a subdomain, but doesn't happen when the subdomain is omitted.

ie: https://sentry.sentry.io/toolbar/sentry/javascript/login-success/ does not redirect properly
but: https://sentry.io/toolbar/sentry/javascript/login-success/ will redirect!

@ryan953
Copy link
Member Author

ryan953 commented Dec 12, 2024

The description of this PR has some more details and outlines the workaround i did: #80003

@github-actions github-actions bot locked and limited conversation to collaborators Dec 29, 2024
@linear linear bot added the Migrated label Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants