Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Empty string) can not be searched #61933

Closed
dachakra opened this issue Dec 18, 2023 · 9 comments
Closed

(Empty string) can not be searched #61933

dachakra opened this issue Dec 18, 2023 · 9 comments

Comments

@dachakra
Copy link

Environment

SaaS (https://sentry.io/)

Steps to Reproduce

  1. Add a scrubbing rule to [Remove] user ID

  2. Find events in Discover with the scrubbed-out user ID:

image

Try to add the empty string to the filter:
!has:user.id
image
user.id:""
image

Expected Result

Return the events with (empty string)

Actual Result

Returns nothing

Product Area

Discover

Link

No response

DSN

No response

Version

No response

@getsantry
Copy link
Contributor

getsantry bot commented Dec 18, 2023

Routing to @getsentry/product-owners-discover for triage ⏲️

@getsantry
Copy link
Contributor

getsantry bot commented Dec 18, 2023

Assigning to @getsentry/support for routing ⏲️

@getsantry getsantry bot moved this to Waiting for: Support in GitHub Issues with 👀 Dec 18, 2023
@getsantry getsantry bot moved this from Waiting for: Support to Waiting for: Product Owner in GitHub Issues with 👀 Dec 18, 2023
@narsaynorath narsaynorath self-assigned this Dec 20, 2023
@narsaynorath
Copy link
Member

Heads up, I'm going to own this and take a deeper look. I'll update with any progress that I make

@endrift
Copy link

endrift commented Feb 16, 2024

Would love a fix with this. I'm trying to make a dashboard based on a tag and I need to filter out rows without that tag being present, and I'm not sure I can do that right now since it shows up as (Empty string)

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 2 Feb 16, 2024
@narsaynorath
Copy link
Member

Hey @endrift, sorry I haven't been able to fix this one yet, other things have taken my attention away from this fix. I've come up with a workaround in the meantime. You can add a version of this filter to your widget: count_if(<YOUR TAG>,equals,""):0

This essentially treats the count as a flag and we can filter out rows where the tag is empty. Please let me know if it works for you!

For my own context, is the empty string something you've explicitly set? Or is it occurring because of a data scrubbing rule? If it's the former, you could have a different value set that's easier to filter out for the future until this is fixed. If the latter and the product is producing empty strings by default we would want to look into that experience.

@endrift
Copy link

endrift commented Feb 17, 2024

It's closer to the former. We try to gather some explicit context about crashes if it's available, but since it's not always available it can be (Empty string). I'm trying to create a dashboard filter of the different counts of the distinct values, but the case where it's not available isn't interesting because it could be anything then.

The workaround seems fine in the meantime, though obviously less than ideal in the long run.

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 2 Feb 17, 2024
@narsaynorath
Copy link
Member

I appreciate the context @endrift. I'm glad to hear the workaround is sufficient for now, I'll update you once again when we're able to get this fixed. Thanks for your patience on this.

@alexjillard
Copy link
Member

This functionality should be available in the product after recent search changes.

@endrift Can you check that this is still an issue for you? You should be able to fulfil this search with user.id is ""

For now I'll close this issue, but if the new functionality isn't what you're looking for, please reopen the issue and let us konw what you're experiencing so we can take a look.

@endrift
Copy link

endrift commented Dec 18, 2024

Which version was this introduced in? We're using self-hosted and are currently on 24.11.0. I can prompt the admin to update if needed.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2025
@linear linear bot added the Migrated label Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Archived in project
Development

No branches or pull requests

5 participants