diff --git a/static/app/views/explore/charts/index.tsx b/static/app/views/explore/charts/index.tsx index a529ca74ca590e..09af7ff11cb6a2 100644 --- a/static/app/views/explore/charts/index.tsx +++ b/static/app/views/explore/charts/index.tsx @@ -20,7 +20,6 @@ import { prettifyParsedFunction, } from 'sentry/utils/discover/fields'; import {DiscoverDatasets} from 'sentry/utils/discover/types'; -import {formatPercentage} from 'sentry/utils/number/formatPercentage'; import {MutableSearch} from 'sentry/utils/tokenizeSearch'; import usePageFilters from 'sentry/utils/usePageFilters'; import usePrevious from 'sentry/utils/usePrevious'; @@ -353,24 +352,31 @@ export function ExploreCharts({query, setConfidence, setError}: ExploreChartsPro /> {dataset === DiscoverDatasets.SPANS_EAP_RPC && ( - {defined(extrapolationMetaResults.data?.[0]?.['count_sample()']) && - defined( - extrapolationMetaResults.data?.[0]?.['avg_sample(sampling_rate)'] - ) - ? tct( - '*[sampleCount] samples extrapolated with an average sampling rate of [sampleRate]', - { + {!defined(extrapolationMetaResults.data?.[0]?.['count_sample()']) + ? t('* Extrapolated from \u2026') + : resultConfidence === 'low' + ? tct('* Extrapolated from [insufficientSamples]', { + insufficientSamples: ( + + + {t('insufficient samples')} + + + ), + }) + : tct('* Extrapolated from [sampleCount] samples', { sampleCount: ( ), - sampleRate: formatPercentage( - extrapolationMetaResults.data[0]['avg_sample(sampling_rate)'] - ), - } - ) - : t('foo')} + })} )} @@ -401,7 +407,7 @@ function useExtrapolationMeta({ const discoverQuery: NewQuery = { id: undefined, name: 'Explore - Extrapolation Meta', - fields: ['count_sample()', 'avg_sample(sampling_rate)', 'min(sampling_rate)'], + fields: ['count_sample()', 'min(sampling_rate)'], query: search.formatString(), version: 2, dataset, @@ -455,3 +461,7 @@ const ChartFooter = styled('div')` margin-top: ${space(1.5)}; margin-bottom: 0; `; + +const InsufficientSamples = styled('span')` + text-decoration: underline dotted ${p => p.theme.gray300}; +`; diff --git a/static/app/views/explore/content.tsx b/static/app/views/explore/content.tsx index 347af2582f4f81..d574f59eff9ccc 100644 --- a/static/app/views/explore/content.tsx +++ b/static/app/views/explore/content.tsx @@ -114,13 +114,6 @@ function ExploreContentImpl({}: ExploreContentProps) { - {confidence === 'low' && ( - - {t( - 'Your low sample count may impact the accuracy of this extrapolation. Edit your query or increase your sample rate.' - )} - - )} @@ -225,11 +218,6 @@ const Body = styled(Layout.Body)` } `; -const ConfidenceAlert = styled(Alert)` - grid-column: 1/3; - margin: 0; -`; - const TopSection = styled('div')` display: grid; gap: ${space(2)};