From 94d5f872367afe327581c3354c658d14662518cb Mon Sep 17 00:00:00 2001 From: Mark Story Date: Wed, 8 May 2024 17:17:59 -0400 Subject: [PATCH] chore(actor) Remove old actor columns Remove now unused actor columns from rule, alertrule, team, grouphistory. These columns were removed from django state in #69784, #69873, #69976, #70090 Refs HC-1178 --- migrations_lockfile.txt | 2 +- .../migrations/0718_remove_actor_columns.py | 53 +++++++++++++++++++ 2 files changed, 54 insertions(+), 1 deletion(-) create mode 100644 src/sentry/migrations/0718_remove_actor_columns.py diff --git a/migrations_lockfile.txt b/migrations_lockfile.txt index a311f852ab3cb8..3900ddc9dcebb1 100644 --- a/migrations_lockfile.txt +++ b/migrations_lockfile.txt @@ -9,5 +9,5 @@ feedback: 0004_index_together hybridcloud: 0016_add_control_cacheversion nodestore: 0002_nodestore_no_dictfield replays: 0004_index_together -sentry: 0717_query_subscription_timebox +sentry: 0718_remove_actor_columns social_auth: 0002_default_auto_field diff --git a/src/sentry/migrations/0718_remove_actor_columns.py b/src/sentry/migrations/0718_remove_actor_columns.py new file mode 100644 index 00000000000000..c3a19b0ca71c03 --- /dev/null +++ b/src/sentry/migrations/0718_remove_actor_columns.py @@ -0,0 +1,53 @@ +# Generated by Django 5.0.4 on 2024-05-08 21:10 + +from django.db import migrations + +from sentry.new_migrations.migrations import CheckedMigration + + +class Migration(CheckedMigration): + # This flag is used to mark that a migration shouldn't be automatically run in production. + # This should only be used for operations where it's safe to run the migration after your + # code has deployed. So this should not be used for most operations that alter the schema + # of a table. + # Here are some things that make sense to mark as post deployment: + # - Large data migrations. Typically we want these to be run manually so that they can be + # monitored and not block the deploy for a long period of time while they run. + # - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to + # run this outside deployments so that we don't block them. Note that while adding an index + # is a schema change, it's completely safe to run the operation after the code has deployed. + # Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment + + is_post_deployment = False + + dependencies = [ + ("sentry", "0717_query_subscription_timebox"), + ] + + operations = [ + migrations.SeparateDatabaseAndState( + state_operations=[], + database_operations=[ + migrations.RunSQL( + sql="ALTER TABLE sentry_team DROP COLUMN actor_id", + reverse_sql="ALTER TABLE sentry_team ADD COLUMN actor_id BIGINT NULL", + hints={"tables": ["sentry_team"]}, + ), + migrations.RunSQL( + sql="ALTER TABLE sentry_rule DROP COLUMN owner_id", + reverse_sql="ALTER TABLE sentry_rule ADD COLUMN owner_id BIGINT NULL", + hints={"tables": ["sentry_rule"]}, + ), + migrations.RunSQL( + sql="ALTER TABLE sentry_alertrule DROP COLUMN owner_id", + reverse_sql="ALTER TABLE sentry_alertrule ADD COLUMN owner_id BIGINT NULL", + hints={"tables": ["sentry_alertrule"]}, + ), + migrations.RunSQL( + sql="ALTER TABLE sentry_grouphistory DROP COLUMN actor_id", + reverse_sql="ALTER TABLE sentry_grouphistory ADD COLUMN actor_id BIGINT NULL", + hints={"tables": ["sentry_grouphistory"]}, + ), + ], + ) + ]