From 6c0f21f6148c4e5460fb94acf1cf7d3a376906dd Mon Sep 17 00:00:00 2001 From: Evan Purkhiser Date: Fri, 25 Oct 2024 13:58:48 -0400 Subject: [PATCH] ref(crons): Correct test_check_timeout large id usage (#79732) The large ID is meant to be set for the MonitorEnvironment not the MonitorCheckIn like it was here. --- tests/sentry/monitors/clock_tasks/test_check_timeout.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/sentry/monitors/clock_tasks/test_check_timeout.py b/tests/sentry/monitors/clock_tasks/test_check_timeout.py index edcafbbb025e25..1b58fc4225a4bf 100644 --- a/tests/sentry/monitors/clock_tasks/test_check_timeout.py +++ b/tests/sentry/monitors/clock_tasks/test_check_timeout.py @@ -42,6 +42,9 @@ def test_timeout(self, mock_produce_task, mock_mark_failed): }, ) monitor_environment = MonitorEnvironment.objects.create( + # XXX(epurkhiser): Arbitrarily large id to make sure we can + # correctly use the monitor_environment.id as the partition key + id=62702371781194950, monitor=monitor, environment_id=self.environment.id, last_checkin=ts, @@ -51,9 +54,6 @@ def test_timeout(self, mock_produce_task, mock_mark_failed): ) # Checkin will timeout in 30 minutes checkin = MonitorCheckIn.objects.create( - # XXX(epurkhiser): Arbitrarily large id to make sure we can - # correctly use the monitor_environment.id as the partition key - id=62702371781194950, monitor=monitor, monitor_environment=monitor_environment, project_id=project.id,