From 6169992ac7f9f9a06f99b1be47f0f0dbf75f7a70 Mon Sep 17 00:00:00 2001 From: Josh Callender <1569818+saponifi3d@users.noreply.github.com> Date: Fri, 13 Dec 2024 17:31:58 -0800 Subject: [PATCH] Remove NOTIFICATION type --- tests/sentry/workflow_engine/models/test_action.py | 6 +++--- tests/sentry/workflow_engine/test_base.py | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/sentry/workflow_engine/models/test_action.py b/tests/sentry/workflow_engine/models/test_action.py index 32251b47c2937a..9f8983c75ad642 100644 --- a/tests/sentry/workflow_engine/models/test_action.py +++ b/tests/sentry/workflow_engine/models/test_action.py @@ -13,7 +13,7 @@ class TestAction(TestCase): def setUp(self): self.mock_event = Mock(spec=GroupEvent) self.mock_detector = Mock(name="detector") - self.action = Action(type=Action.Type.NOTIFICATION) + self.action = Action(type=Action.Type.SLACK) def test_get_handler_notification_type(self): with patch("sentry.workflow_engine.registry.action_handler_registry.get") as mock_get: @@ -22,7 +22,7 @@ def test_get_handler_notification_type(self): handler = self.action.get_handler() - mock_get.assert_called_once_with(Action.Type.NOTIFICATION) + mock_get.assert_called_once_with(Action.Type.SLACK) assert handler == mock_handler def test_get_handler_webhook_type(self): @@ -49,7 +49,7 @@ def test_get_handler_unregistered_type(self): self.action.get_handler() # Verify the registry was queried with the correct action type - mock_get.assert_called_once_with(Action.Type.NOTIFICATION) + mock_get.assert_called_once_with(Action.Type.SLACK) def test_trigger_calls_handler_execute(self): mock_handler = Mock(spec=ActionHandler) diff --git a/tests/sentry/workflow_engine/test_base.py b/tests/sentry/workflow_engine/test_base.py index edf4cb531bc4b2..3543af270134c5 100644 --- a/tests/sentry/workflow_engine/test_base.py +++ b/tests/sentry/workflow_engine/test_base.py @@ -108,7 +108,7 @@ def create_workflow_action( action_group = self.create_data_condition_group(logic_type="any-short") action = self.create_action( - type=Action.Type.NOTIFICATION, + type=Action.Type.SLACK, data={"message": "test"}, **kwargs, )