From 600b66fc82a702bb6fd323c04f5e2dc1334dd099 Mon Sep 17 00:00:00 2001 From: Michelle Zhang <56095982+michellewzhang@users.noreply.github.com> Date: Thu, 12 Oct 2023 13:54:17 -0700 Subject: [PATCH] fix(replays): don't overfetch url (#58012) since we deleted our `StringWalker` / displaying URLs in the `ReplayCell`, we no longer need to fetch URLs --- fixtures/js-stubs/replayList.ts | 1 - .../app/views/issueDetails/groupReplays/groupReplays.spec.tsx | 1 - static/app/views/replays/deadRageClick/exampleReplaysList.tsx | 1 - static/app/views/replays/types.tsx | 2 -- 4 files changed, 5 deletions(-) diff --git a/fixtures/js-stubs/replayList.ts b/fixtures/js-stubs/replayList.ts index 5bd512264f117a..07a0ab9cb73cc6 100644 --- a/fixtures/js-stubs/replayList.ts +++ b/fixtures/js-stubs/replayList.ts @@ -28,7 +28,6 @@ export function ReplayList( }, project_id: '2', started_at: new Date('2022-09-15T06:50:03+00:00'), - urls: [], user: { display_name: 'testDisplayName', email: '', diff --git a/static/app/views/issueDetails/groupReplays/groupReplays.spec.tsx b/static/app/views/issueDetails/groupReplays/groupReplays.spec.tsx index e4a4c4a47d68e1..581865c791c643 100644 --- a/static/app/views/issueDetails/groupReplays/groupReplays.spec.tsx +++ b/static/app/views/issueDetails/groupReplays/groupReplays.spec.tsx @@ -137,7 +137,6 @@ describe('GroupReplays', () => { 'os', 'project_id', 'started_at', - 'urls', 'user', ], per_page: 50, diff --git a/static/app/views/replays/deadRageClick/exampleReplaysList.tsx b/static/app/views/replays/deadRageClick/exampleReplaysList.tsx index dd7947e9707c9e..c60a748866edae 100644 --- a/static/app/views/replays/deadRageClick/exampleReplaysList.tsx +++ b/static/app/views/replays/deadRageClick/exampleReplaysList.tsx @@ -53,7 +53,6 @@ export default function ExampleReplaysList({ 'finished_at', 'is_archived', 'started_at', - 'urls', ], projects: [projectId], query: selectorQuery, diff --git a/static/app/views/replays/types.tsx b/static/app/views/replays/types.tsx index b5d2936ed51067..721067eff1adbc 100644 --- a/static/app/views/replays/types.tsx +++ b/static/app/views/replays/types.tsx @@ -124,7 +124,6 @@ export const REPLAY_LIST_FIELDS = [ 'os.version', 'project_id', 'started_at', - 'urls', 'user', ]; @@ -143,7 +142,6 @@ export type ReplayListRecord = Pick< | 'os' | 'project_id' | 'started_at' - | 'urls' | 'user' >;