From 387b90038b949c1a3f25fb5ab2f6f8506b0c148a Mon Sep 17 00:00:00 2001 From: Ash <0Calories@users.noreply.github.com> Date: Thu, 12 Dec 2024 12:50:36 -0500 Subject: [PATCH] fix(trace-view): Incorrect indicator scores (#81991) In a previous PR, the score set on the indicator is already multiplied by 100 beforehand, so the multiplication in here is incorrect and is inflating the score value. --------- Co-authored-by: Jonas Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com> --- static/app/views/performance/newTraceDetails/trace.tsx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/static/app/views/performance/newTraceDetails/trace.tsx b/static/app/views/performance/newTraceDetails/trace.tsx index dbfa6e5041c853..2ccc83a14bd831 100644 --- a/static/app/views/performance/newTraceDetails/trace.tsx +++ b/static/app/views/performance/newTraceDetails/trace.tsx @@ -401,10 +401,10 @@ export function Trace({ > {trace.indicators.length > 0 ? trace.indicators.map((indicator, i) => { - const score = indicator.score - ? Math.round(indicator.score * 100) - : undefined; - const status = score ? STATUS_TEXT[scoreToStatus(score)] : 'none'; + const status = + indicator.score === undefined + ? 'none' + : STATUS_TEXT[scoreToStatus(indicator.score)]; return (